5 replies to this topic

[aazamsajid]

i am working on a tic tac toe game this is loop code ....how can write this in short way like in algorthm or arrays etc

void check()
	    {
		    if (b[0].Text == b[1].Text && b[1].Text == b[2].Text && b[0].Text != "")//
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[3].Text == b[4].Text && b[4].Text == b[5].Text && b[3].Text != "")//
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[6].Text == b[7].Text && b[7].Text == b[8].Text && b[6].Text != "")//
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[0].Text == b[3].Text && b[3].Text == b[6].Text && b[0].Text != "")//
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[1].Text == b[4].Text && b[4].Text == b[7].Text && b[1].Text != "")//
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[2].Text == b[5].Text && b[5].Text == b[8].Text && b[2].Text != "")//6
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[0].Text == b[4].Text && b[4].Text == b[8].Text && b[0].Text != "")//7
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		    if (b[2].Text == b[4].Text && b[4].Text == b[6].Text && b[2].Text != "")//8
		    {
			    MessageBox.Show(b[0].Text + " wins");
			    reset();
		    }
		  
	   
	   
	    }

[BlackRabbit]

Here is your shortie :

Bool checkForWin( int c1, int c2, int c3 )
{
	if (b[c1].Text == b[c2].Text && b[c2].Text == b[c3].Text && b[c1].Text != "")
    {
	    return true;
    }

    return false;
}

void check() 
{
    if ( checkForWin( 0,1,2 ) || checkForWin( 3, 4, 5 ) || // put here all the combinations )
    {
		 MessageBox.Show(b[0].Text + " wins");
	     reset();
	}
}

[Soryy708]

static bool is_Row()
{
	int CurX;
	int CurY;

	for(CurY = 0; CurY < 3; CurY++) /* Rows */
		if(b[CurY*3].Text == b[1 + CurY*3].Text == b[2 + CurY*3].Text)
			return true;

	for(CurX = 0; CurX < 3; CurX++) /* Columns */
		if(b[CurX].Text == b[CurX + 1*3] == b[CurX + 2*3])
			return true;

	if(b[0].Text == b[1 + 1*3].Text == b[1 + 2*3].Text ||
	   b[3 + 2*3].Text == b[2 + 2*3] == b[1 + 1*3])
		   return true;

	return false;
}

void check()
{
	if(is_Row())
	{
		MessageBox.Show(b[0].Text + " wins"));
		reset();
	}
}

[BlackRabbit]

Is_row does not work for diagonals, you will get index out of bounds error :

this should be the correct version of is_row "

static bool is_Row()
{
    int CurX;
    int CurY;

    for(CurY = 0; CurY < 3; CurY++) /* Rows */
        if(b[CurY*3].Text == b[1 + CurY*3].Text == b[2 + CurY*3].Text)
            return true;

    for(CurX = 0; CurX < 3; CurX++) /* Columns */
        if(b[CurX].Text == b[CurX + 1*3] == b[CurX + 2*3])
            return true;

 if(b[0].Text == b[4].Text == b[8].Text ||
       b[2].Text == b[4] == b[6])
           return true;

    return false;
}

[Soryy708]

This is the beauty of open source and free software.

[aazamsajid]

when i apply is_row method this error is occrng.

An object reference is required for the non-static field, method, or property 'WindowsFormsApplication1.Form1.b'