7 replies to this topic

[pointish]

qqq

Edited by pointish, 27 January 2012 - 09:32 AM.

[voral]

1.
not right:

Quote

scanf("%d", j);

right:

Quote

scanf("%d", &j);

[pointish]

yex tnx have to remember this things

[Sysop_fb]

Also

string = realloc(string, capacity);

Using the pointer to your old memory to hold the return value of a realloc call is bad form, if that call fails then realloc isn't required to clean up the old allocated memory and you just lost your pointer to it so now you have a memory leak. Most people will use a temp pointer to hold the realloc call to check if it's null and then move your original pointer to the temp one.

Type casting malloc and realloc is pretty useless as well since C does type coercion from void to any other type automatically.

[voral]

Sysop_fb said:

Type casting malloc and realloc is pretty useless as well since C does type coercion from void to any other type automatically.

I think it is useful for code clarity

[Sysop_fb]

Yeah if you need clarity it can help if you know what you're doing.
It can cause problems as well and I usually recommend newer programmers to stay away from it. Depending on the compiler you're using if you cast malloc and forget to include the stdlib.h header file you could end up with broken code that compiles. Personally I'd just add a comment block if I need clarity that bad over telling the compiler that you're smarter than it via casting when it's not necessary.

FAQ: Casting malloc?
Question 7.7

[voral]

Yeah, right. Yeah, right. I did not think about it.

[pointish]

hi i did some changes, is there a way to check that the memory allocation is succeeded?
because when i wright very big numbers it just ends the prog without gvining a message that allocation failed?!