3 replies to this topic

[woohooXX]

Hello, i have a task, to create program which finds all negative values in vector and calculates average of all found negative values. So far i have done this:

.model tiny

.code

.startup

           Org 100h

           Jmp Short Start

Vector     Dw  2, 7, -1, 16, 15

N          Equ 5


Start:

           Xor  Bx, Bx

           Xor  Si, Si

           Mov  Cx, N

S:

           Mov  Ax, Vector[Bx]   

           Add  Bx, 2

           Cmp  Ax, 0

           Jle  _next

           Add  Dx, Ax

           Inc  Si         


_next:     Loop S

           Idiv Si



           


.exit 0

end

But I have real troubles figuring out the end of program, which calculates this average value. I would be very thankful if someone could help me with this, because it would help me to understand how this thing works, for now, i can't figure it out, i think i`m not good at this and probably wont be, because we have assembly only for first semester and it won't help me to understand it fully :/

[RhetoricalRuvim]

woohooXX said:

Jle  _next

Don't you mean

j[COLOR=#FF0000][B]g[/B][/COLOR]e _next

? I mean, you're only interested in values less than 0, you're not interested in omitting values that are less than 0, what you're doing in the code you posted.


As for the ending, you mean outputting the result?

[woohooXX]

I rewrote my code in different way:

.model tiny

.code

.startup

           Org 100h

           Jmp Short Start

Vector     Dw  2, -7, -1, 16, -15

N          Equ 5


Start:


           Xor Bx, Bx

           Xor Dx, Dx

           Xor Si, Si

           Mov Cx, N

           Dec Cx

S:

           Mov Ax, Vector[Bx]   

           Add Bx, 2

           Cmp Ax, 0

           Jge _next

           Inc Si

           Add Dx, Ax

           

_next:     

           Dec Cx

           Loop S


AVG:

           Mov Ax, Dx

           Cwd

           Idiv Si


.exit 0

end

I need to save average values in Ax register and print them out, but when I check my results they are kinda wrong

[dargueta]

Try getting rid of the dec cx right before the beginning of the loop.