5 replies to this topic

[lol33d]

hi guys

i want create a update query

this is my code, and no problem for use:

		mysql_query("UPDATE `tblhistory` SET `ouhSTATUS` = 'Pess' WHERE `ouhSELECTION` = '' AND `ouhID` = '" . $row[''] . "'");

	


		mysql_query("UPDATE `tblhistory` SET `ouhSTATUS` = 'Pess' WHERE `ouhSELECTION` = '' AND `ouhID` = '" . $row[''] . "'");


	mysql_query("UPDATE `tblhistory` SET `ouhSTATUS` = 'Ive' WHERE `ouhID` = '" . $row['ouhID'] . "'");


}

but i want create a query for up speed


i want create a query Instead of 3 query



but it have problem, please fix this query for me

thank you so much

Edited by lol33d, 04 December 2011 - 03:13 AM.

[WingedPanther]

To my mind, you're making it too complicated, and you're doing some strange stuff.

1) ouhLINEID is varchar, but you want to treat it like a double. That just seems a bit odd. Floor seems likely to have unpredictable results for that.

2) Your main issue is not that you have too many queries, but that you're calling them in a loop. Using 3 queries with a better, yet simple, where clause would work fine.

3) it looks like you're setting id's to InActive, regardless of the OVER/UNDER choice.

Why not do the following?

$num = 2;
mysql_query("UPDATE `tblhistory` SET `ouhSTATUS` = 'Process' WHERE `ouhSELECTION` = 'UNDER' AND `ouhSTATUS` = 'Active' AND `ouhLINEID` in ('0.5','1.5','2.5')");

mysql_query("UPDATE `tblhistory` SET `ouhSTATUS` = 'Process' WHERE  `ouhSELECTION` = 'UNDER' AND `ouhSTATUS` = 'Active' AND `ouhLINEID` in  ('3.5','4.5')");

mysql_query("UPDATE `tblhistory` SET `ouhSTATUS` = 'InActive' WHERE  `ouhSELECTION` = 'UNDER' AND `ouhSTATUS` = 'Active'");

[lol33d]

thank you WingedPanther

i need (if statement) in query

please convert my function to my query

Edited by lol33d, 04 December 2011 - 03:19 AM.

[WingedPanther]

Why?

Seriously, is this a homework assignment, or what? Why are you worried about using 1 query instead of 3?

[lol33d]

is not homework, i need 1 query with if statement

[WingedPanther]

Why?

Here's the deal. The queries I gave you should add a huge speed boost, but doing conditional logic in the queries may or may not trash that. Regardless, which database type are you hitting, as the syntax would vary from one type to another.