8 replies to this topic

[lva28]

I need assistance since it keeps outputting 8.00 when it should be different if the weight is over 50

float CalcShipping(int &totalWt,)

{

    if (totalWt <= 25)

  {

    return 8.00;

  }

  else if (totalWt <= 50)

  {

    return (totalWt - 25) *.15 + 8.00;

  }

  else if (totalWt > 50)

  {

    return (totalWt - 25) *.09 + 8.00;

  }

}

Edited by lva28, 01 December 2011 - 06:01 PM.

[gregwarner]

I don't see anywhere where you've initialized totalWt. In C/C++, you need to initialize your variables or else they have unpredictable starting values based on whatever happens to be in memory before they're allocated.

Edit: To put it simply: Don't assume your variables start with a value of zero unless you explicitly initialize them as so.

[lva28]

Thanks for the tip I initialized it and it still always returns $5.00, did you see any other reasons why this is so?

[WingedPanther]

You set totalWt to 0, then check to see if it's less than 25. It always will be.

[Flying Dutchman]

The problem is this line:

totalWt=0.00;

In your CalcShipping function, you initialize it and then the function returns $5 because 0 is smaller than 25.

Also, a small tip; you don't have to use break for each case in switch statements, if you want several cases to do the same thing.

case 'o':
    cout << "Orange County";
    break;
case 'O':
    cout << "Orange County";
    break;

So you can change that to this:

case 'o':
case 'O':
    cout << "Orange County";
    break;

[lva28]

I initialized it after I posed the problem because the first responder told me to initialize totalWt to 0. Without initializing it, totalWt still always returns 5.00, is there another solution other then the initialization?

[Flying Dutchman]

You should initialize it in main function, not in CalcShipping.

[gregwarner]

Initialize it when you declare it, before you pass it to any functions.

[lespauled]

1. Why is the parameter a reference? I don't think it's necessary, since you are not doing anything to it. You are just reading it.
2. As a programming practice, the last (else if ) is not necessary. It can simply be an else, since everything else is covered.