4 replies to this topic

[toto_7]

Hello,

How i can make the algorithm below more efficiently?

boolean isP(String s){


   boolean bP = true;

   for(int i=0; i<s.length(); i++){

      if(s.charAt(i)!=s.charAt(s.length()-i-1)){

         bP=false;

      }

   }

   return bP;

}

I thought insert a

break;

exaclty after

bP=false;

, to terminate the algorithm, there is any better solution?
Thank you

[WingedPanther]

What about this:

boolean isP(String s){
     boolean bP = true;
    for(int i=0; i<(s.length()/2) && bP; i++){
       if(s.charAt(i)!=s.charAt(s.length()-i-1)){
          bP=false;
       }
    }
    return bP;
 }

[toto_7]

An explanation on this please??

Thank you

[WingedPanther]

First, since you're testing for palindromeness, you only have to go half-way through the string, as you've already compared the second half to the first half.
Second, as soon as you find a failure, the loop condition will now fail, breaking the loop.

[toto_7]

Ok, now its clear, thank you