11 replies to this topic

[ivan711]

Guys i gt an error in my codes, it can build n compile bt it nt working properly..
N one more thing guys am really newbie in programming n to tis forum. hope u all can lead me a helping hand. Here is de codes.

#include <stdio.h>

int add( int, int);
int sub( int, int);
int product( int, int);
int divide( int, int);

int main()
{
    int num1, num2;
    char operation, choice;

    printf("\n\nSimple Calculator Program\n");

        printf("\nEnter a number =>\t");
        scanf("%d", &num1);
        printf("\nEnter your operator (+, -, *, /), Followed by another number =>\t");
        scanf("%d%c%d", &num1, &operation, &num2);

        if (operation == '+')
            printf("Current value:\t%d", add(num1,num2));

        if (operation == '-')
            printf("Current value:\t%d", sub(num1,num2));

        if (operation == '*')
            printf("Current value:\t%d", product(num1,num2));

        if (operation == '/')
            printf("Current value:\t%d", divide(num1,num2));

        printf("\nDo you wish to continue[y/n]\t");
        scanf("%s",&choice);
        if(choice=='y'||choice=='Y')
            main();
}

    int add( int num1, int num2)
    {
        return(num1+num2);
    }

    int sub( int num1, int num2)
    {
        return(num1-num2);
    }

    int product( int num1, int num2)
    {
        return(num1*num2);
    }

    int divide( int num1, int num2)
    {
        return(num1/num2);
    }

Edited by Alexander, 12 June 2011 - 08:39 PM.

[WingedPanther]

How do you know it's not working properly? What inputs are producing incorrect results?

[robbiewoods05]

#include <stdio.h>


int add( int, int);

int sub( int, int);

int product( int, int);

int divide( int, int);


int main()

{

int num1, num2;

char operation, choice;


printf("\n\nSimple Calculator Program\n");


printf("\nEnter a number =>\t");

scanf("%d", &num1);

printf("\nEnter your operator (+, -, *, /), Followed by another number =>\t");

scanf("%d%c%d", &num1, &operation, &num2);


if (operation == '+')

printf("Current value:\t%d", add(num1,num2));


if (operation == '-')

printf("Current value:\t%d", sub(num1,num2));


if (operation == '*')

printf("Current value:\t%d", product(num1,num2));


if (operation == '/')

printf("Current value:\t%d", divide(num1,num2));


printf("\nDo you wish to continue[y/n]\t");

scanf("%s",&choice);

if(choice=='y'||choice=='Y')

main();

}


int add( int num1, int num2)

{

return(num1+num2);

}


int sub( int num1, int num2)

{

return(num1-num2);

}


int product( int num1, int num2)

{

return(num1*num2);

}


int divide( int num1, int num2)

{

return(num1/num2);

}

isn't %d for doubles not ints?

[AKMafia001]

It seems that the problem is in the way of insertion.
First remove the additional insertion,

printf("\nEnter a number =>\t");

scanf("%d", &num1);

Now insert the expression combinedly and press enter at the end,

2+6 [enter]

By doing this you will get,

Current value:    8

Use a while loop instead of calling main() again; This will define the variables again -- occupying different memory location (Probably the same).
Try to create the same program in different ways, using if-else, switch.

Hope this helped!

[Flying Dutchman]

Another thing is to check for division by zero, unless you've figured out how to. :)

[ivan711]

when i input first num den followed by operation with second number it nt calculating n produce result..

[ivan711]

i do gt this method.. bt de task give to me to ask the user to put first input den second instruction to input operation together with second number..after that only produce result. Bt it nt showing any result bt direct the user to continue or nt..

[ivan711]

Seriously i duno abt tat..

[ivan711]

robbiewoods05 : as i checked %d is for int while &f(printf) n &lf(scanf) for double

[Alexander]

You should call add() or appropriate functions within your if statements for the operator. main() will call the input again or worse.

Your code seems alright for now, try doing this and give us your new code even if it does not work as expected so that you may learn from it.

[robbiewoods05]

i though %i was for an int but i'm probably wrong

[Alexander]

robbiewoods05 said:

i though %i was for an int but i'm probably wrong

i and d are synonymous, although i is more clear (an integral numeric.) decimal (or denary, %d) means in tens or base ten, including base ten fractions.