4 replies to this topic

[camouser1s]

This is the question from the assignment itself:
-Write a function template that returns the range of values stored in a vector, that is, the difference between the largest value and the smallest value, when operator < is assumed to be defined for type T.

This is what I have:

template <typename T>

int Range(vector<T> vec)

{

   for(int i = 0; i < (vec.size() - 1); i++)

     {

        while (vec[i] < vec[i + 1])

          {

             return (vec.begin() - vec.end());

           }

      }

}

How does this look? Feedback and criticism is appreciated. Thanks :)

[WingedPanther]

You haven't found the largest or smallest values, just the consecutive differences.

[Flying Dutchman]

You are actually returning negative vector's size. Your return statement is equivalent to this:

return 0 - vec.size();

[camouser1s]

could i just do the min and max values with iterators ?

[WingedPanther]

You need to have a couple extra variables to keep track of the values pointed to by the iterators.