10 replies to this topic

[gelembjuk]

Hello,
I found that FTP wrapper in PHP works wrong.

Simple code:

$link='ftp://mylogin:mypassword@myhost.com:21/domains/folder1/folder2/123changes.doc';


$h=fopen($link,'r');

if(!$h){

 echo 'bad';

}else

 echo 'good';

This code always shows 'good'. Even file doesn't exists on FTP server. There is no file 123changes.doc in folder 'folder2'. But fopen returns correct handle.

What is wrong in my code?

[John]

I'd recommend using the ftp_ set of functions instead. PHP: FTP Functions - Manual

[gelembjuk]

John said:

I'd recommend using the ftp_ set of functions instead. PHP: FTP Functions - Manual

this set of function is good but not for me.
I need to have opened handle and read file with portions.
My code looks like:

$handle = fopen("ftp://example.com/folder/file.doc", "r");


while (!feof($handle)) {

  $data= fread($handle, 8192);

  //do something with data

}

fclose($handle);

There is no ftp_ function that can return handle.
Any idea? Is this bug in my php installation (that handle is always opened even if file doesn't exists)?

[John]

For me, the code in your original post throws a warning and does not create a handle. Perhaps you can try the following:

$link='ftp://mylogin:mypassword@myhost.com:21/domains/folder1/folder2/123changes.doc'; 
if(!file_exists($link))
    die("The file does not exist");

$h=fopen($link,'r'); 
if(!$h){ 
 echo 'bad'; 
}else 
 echo 'good';  
}

[gelembjuk]

John said:

For me, the code in your original post throws a warning and does not create a handle. Perhaps you can try the following:

$link='ftp://mylogin:mypassword@myhost.com:21/domains/folder1/folder2/123changes.doc'; 

if(!file_exists($link))

    die("The file does not exist");


$h=fopen($link,'r'); 

if(!$h){ 

 echo 'bad'; 

}else 

 echo 'good';  

}

Thanks for your advice.
But this doesn't help me.
function file_exists always returns FALSE for me. Even if file exists.
There is something definitely wrong with this wrapper in my installation.

I have found one solution, but it is very slow. I just list all files in directory of FTP server and see if needed file is there. I still want to find good solution for this problem.

[gelembjuk]

To solve my problem i use function ftp_size to check if file exists before downloading it.
But i still don't know what is the problem with my wrapper.

[Alexander]

If you'd rather hack up a way than to use ftp_* functions go ahead, but you'll need to do some tricky things:

$link = 'ftp://anonymous@ftp9.us.postgresql.org:21/pub/mirrors/postgresql/README'; //Sample
if(!$h = @fopen($link,'r')) {
    print "bad";
} else {
    print "good";
    $sData = "";
    while(!feof($h))
        $sData .= fread($h, 4024);
    fclose($h);
}

You won't need to use ftp_size to check if it exists now, although I'd recommend to just stick with alternates to fopen() for that.

[gelembjuk]

Nullw0rm said:

If you'd rather hack up a way than to use ftp_* functions go ahead, but you'll need to do some tricky things:

$link = 'ftp://anonymous@ftp9.us.postgresql.org:21/pub/mirrors/postgresql/README'; //Sample

if(!$h = @fopen($link,'r')) {

    print "bad";

} else {

    print "good";

    $sData = "";

    while(!feof($h))

        $sData .= fread($h, 4024);

    fclose($h);

}

You won't need to use ftp_size to check if it exists now, although I'd recommend to just stick with alternates to fopen() for that.

What alternatives to fopen() do you mean?



I have tried your example with little modificztion:

$link = 'ftp://anonymous@ftp9.us.postgresql.org:21/pub/mirrors/postgresql/README22'; //Sample

if(!$h = @fopen($link,'r')) {

    print "bad";

} else {

    print "good";

    $sData = "";

    while(!feof($h)){

	    echo '<br>read';

        $sData .= fread($h, 4024);

    }

echo $sData;

    fclose($h);

}

That file doesn't exists and i still see 'good'. echo $sData; shows nothing. $sData is empty.
I see:
good
read

[Alexander]

Your exact code reports the file as "bad" for me, as we're getting inconsistant results you should best be using proper FTP functions rather than fopen's wrapper:
http://ca3.php.net/m.../en/ref.ftp.php

[wim DC]

appearantly the fopen returns false only when an error occured. And a non-existing file isn't handled as error.

if (file_exists("myfile.php"))

source: PHP ::

[Alexander]

oxano said:

appearantly the fopen returns false only when an error occured. And a non-existing file isn't handled as error.:[/url]

That's why I used the presidence to check if fopen returns a warning (550 from FTP that file doesn't exist), for some reason his installation doesn't report it.