5 replies to this topic

[denarced]

I have the following:

bool operator==(Siirto& rSiirto)
{
    if(from == rSiirto.from && to == rSiirto.to)
       return true;
    else
       return false;
}

I'm in the process of improving my code and thus making it more easy to test.
Unit testing is a big part of it.
Let's say the variable rSiirto == null.
Should this be an exception or just return false?
I'm thinking this is matter of taste and preference but I read that one should only
raise exceptions if the condition is exceptional so you should never raise exceptions
unless something truly exceptional has happened..

Thoughts?

[JCoder]

I think you should simply return false in this case.

BTW:
1. Good code does not need null.
2. Exception-safe C++ coding is difficult.

[WingedPanther]

It depends. Is rSiirto being null an exception condition?

[denarced]

I don't think it possibly could be. It's just an operator==

[WingedPanther]

if rSiirto is null, you'll generate an access violation.

[julmuri]

Hmm rSiirto is reference so it can not be null. Afaik.
So your function should be just fine.