7 replies to this topic

[Moudi]

#include<stdio.h>

#include<stdlib.h>

void saveem()

{

    system("cls");

    char buffer[80];

    FILE *fp, *fp2;

    int c;

    fp=fopen("C:\Users\Moudi\Desktop\hahaaoida.txt", "a");

	fp2=fopen("C:\Users\Moudi\Desktop\hahaaoida2.txt", "a");

    fgets(buffer, 80, stdin);

    fprintf(fp, "%s", buffer);

	system("cls");

	fclose(fp);

    while ((c=fgetc(fp))!=EOF)

    {

        fputc(c+4, fp2);

    }

    printf("Done!\n");

	fclose(fp);

	fclose(fp2);

}

void deleteem()

{

    remove("C:/test.txt");

}

void showem()

{    

    int a;

    char character;

    FILE *file,*file2;

    file=fopen("C:/test.txt", "rb");

    file2=fopen("C:/test2.txt", "wb");

    while ((a=fgetc(file))!=EOF)

    {

        fputc(a-4, file2);

    }

    fclose(file);

    while ((character=fgetc(file2)) != EOF) {

    putchar(character);

    }

    fclose(file2);

    remove("C:/test2.txt");

}

int main()

{

    char buffer2[20];

    int input;

    printf("1.Write something in test.txt");

    printf("\n2.Delete test.txt\n");

    printf("3.Show the content of test.txt\n");

    scanf("%d", &input );

    switch (input) {

        case 1:

            saveem();

            break;

        case 2:

            deleteem();

            break;

        case 3:

            showem();

            break;

        default:

            printf(" Bad input, Quitting!\n");

            break;

    }

    getchar();

    return 0;

}

So what's happening here if i input "1" it will only show "Done" without asking for the buffer and it won't write it to the file specified.

[WingedPanther]

Are you sure that fp actually points to a file, rather than being null?

[Moudi]

Yea i accually created the file also ( the program should create it by itself )

[WingedPanther]

You aren't checking fp to ensure it isn't null before writing to it. You may want to dump buffer to screen as well, just to ensure that it was read correctly.

[dcs]

Using scanf for user input nearly always ties newbs in knots. I therefore generally recommend taking all user input as strings and converting to numeric if necessary.

A short explanation is that when you respond to the request for numeric input, you press enter. This value -- the newline -- is not discarded but remains in the input buffer. Mixed with a call for string data, the newline will immediately satisfy the call without pausing for user input. So if you don't take the user input as a string as I earlier suggested, then you will have to clean up the input stream to get rid of the newline.

[Moudi]

I'm really bad at this, Can someone clean it up for me and explain a little ? ( Try staying away from hard language :P )

[Guest]

Instead of this:

fp=fopen("C:\Users\Moudi\Desktop\hahaaoida.txt", "a");

fp2=fopen("C:\Users\Moudi\Desktop\hahaaoida2.txt", "a");

Try this:

fp=fopen("C:\\Users\\Moudi\\Desktop\\hahaaoida.txt", "a");

fp2=fopen("C:\\Users\\Moudi\\Desktop\\hahaaoida2.txt", "a");

Backslashes are interpreted as escape characters, so you need two backslashes instead of just one. Also, you should always check to see if your files opened correctly. If the file pointer is NULL, print an error and exit with failure:

if (fp==NULL) {

    printf("Error opening file!\n");

    return 1;

}

[dcs]

Alternatively, use forward slashes.