4 replies to this topic

[jeremy1984]

i'm doing a card game, and i'm having error with my shuffling routine
it's not working probably ,, what should i do?

this is my shuffling routine, would you plz tell me what is the problem with my code...

 public void shuffle()
                      {
    
                       List<card> shufCards=new List<card>(52);
                       Random rand=new Random();
                       for (int i = 0; i < cards.Count; i++)
                         {
                           int c = rand.Next(cards.Count); 
                           shufCards.Add(cards[c]);
                           cards.RemoveAt(c);
                         }
                                              
                        cards = shufCards;
                       }

Edited by Jaan, 15 November 2009 - 12:14 PM.
Please use code tags when you are posting your codes !

[bennis]

As cards.count is changing according to cards.removeAt(),
so, it should be

int temp=cards.count;

for(int i=0;i<temp;i++){

}

[Orjan]

why shuffle the deck? why not just randomize one at a time from the deck?

[FlashM]

I think this depends on the card game... Is there only one deck? If true, Orjan has the best solution for now. Just randomize one at a time from the deck.

[Orjan]

That method works with as many decks as well, just having an array to check off used cards in... and of course, you randomizes all decks then...