7 replies to this topic

[Hawk1]

OK... drivers and arrays are hard!!!!!!!

i think this code may be right, but will someone check it to make sure it looks ok?

here is the project

Quote

Write a function that will fill an array with 25 random numbers between 1 and 10. Then write a function that will print out the array. Write a driver that will test your functions

Do not use global variables here. Pass the array to the function through the parameter list

here is the code

#include <iostream>  

#include <ctime>  

using namespace std;  

  


void printFunc(int[]);  

void fillFunc(int[]);  

  

int main()  

{  

int random[25]; //0-24 is 25 since array indeices  

srand((unsigned)time(NULL));  

fillFunc(random);  

printFunc(random);  

return 0;  

}  

  

void fillFunc(int arr[])  

{  

        for (int i = 1; i < 25; i++)  

        {  

                    arr[i] = 1+ rand() % 10;  

         }  

  

}  

  

void printFunc(int arr[])  

{  

          for (int i = 1; i < 25; i++)  

          {  

                    cout << arr[i];  

         }  

}  

[WingedPanther]

Two quick questions:
1) does it compile?
2) does it appear to run correctly?

I suspect your output (assuming it compiles/runs) will immediately make one limitation on your code apparent. I would also read up on the rand() function.

[Hawk1]

1) yes it compiles
2) it runs....... idk about correctly?

theres no spaces between the numbers, it looks like this 1101328448174183742547656 Press any key continue....

whats the limitation you speak of?

thanks for your help

[dargueta]

Change this:

void fillFunc(int arr[])  
{  
        //start indexing from 0, not 1. arrays start at 0.
        for (int i = 0; i < 25; i++)  
        {  
                    arr[i] = 1+ rand() % 10;  
         }  
  
} 
void printFunc(int arr[])  
{  
          //you're always skipping the first element. arrays
          //are always started counting at 0.
          for (int i = 0; i < 25; i++)  
          {  
                    //put spaces between numbers
                    cout << arr[i] << " ";  
         }
         cout << endl;
}

You were very close to a good implementation; you just needed to put spaces between the numbers and an endl at the end to shift "Press any key to continue..." to the next line. Just remember that arrays are always indexed from 0, not 1.

[WingedPanther]

Whenever you're producing output, you want to make sure it is readable (such as adding spaces like dargueta suggested). When you have a question on your program, providing the output and any behaviors of concern can be a great help. When dealing with random numbers, do a few runs to verify that the output appears to be random (I had a Tetris game that didn't initialize the RNG, so I always got the pieces in the same order).

[Hawk1]

thank you so much for the help everyone! that ran perfect, such little stupid mistakes i do. :)

[Steve.L]

Looks like you're getting better at coding Hawk1. Keep it up!

[Hawk1]

thanks steve, its the hardest thing i've ever had to do, but thank goodness for this forum to help me get through it.