14 replies to this topic

[Hawk1]

I'm getting this warning

Quote

1> warning C4244: 'argument' : conversion from 'time_t' to 'unsigned int', possible loss of data

for this code chunk

int genRandom()

{

    int r;

    srand(time(NULL));

    r = rand() % 100 + 1;

    

    return r;

}

that int is assigned, why is it telling me this nonsense?

[LukeyJ]

It is referring to the time() function inside the srand() function.

srand() takes the argument int, time() returns a variable of type_t. I don't understand enough about what you are doing or why you use these functions, but if you want this to occur, you may need to explicitly cast the variable.

srand(static_cast<int>time(NULL));

You may need () brackets round the time function return you are casting. This is just to let the compiler know you are aware that it is casting a variable to type int and this is the behaviour you want to occur.

[Aereshaa]

Just use a normal cast.
srand((int)time(NULL));

[dcs]

Hawk1 said:

I'm getting this warning





for this code chunk

int genRandom()

{

    int r;

    srand(time(NULL));

    r = rand() % 100 + 1;

    

    return r;

}

that int is assigned, why is it telling me this nonsense?

Don't call srand with every rand call, it doesn't do what you think it does.
Question 13.17

[Hawk1]

thanks! ill have to try that

[marwex89]

Aereshaa said:

Just use a normal cast.
srand((int)time(NULL));

That is not a "normal" cast in C++! That is a C-style cast.. As you of course know. But C-style casts in C++ are "not encouraged and commonly looked down upon".

[Aereshaa]

Because you're jealous of our beautiful syntax! :p

[Hawk1]

while you guys are in the thread....... how would i turn say, this.....

char newgame = 'y';

into a Toupper that actually works
or is that not the right context where to put the toupper

maybe here?

 cout << "Do you want to play again? (y / n)" << endl;

            cin >> newgame;

[LukeyJ]

Incorrect. There is more than one cast in c++. Being specific is very useful. It also makes you aware of the behaviour that is occurring or atleast a point of reference. If you don't know that the compiler is making assumptions on your behalf, it limits your ability to fully understand how the language behaves. Which is very useful for newer programmers like myself :D. C++ is a different language. Backwards compatibility is not a purity in a language, it just makes it easier for conversion and popularity. The more impure a language is, the more inconsistant it is!

[dcs]

Regarding casts, I'd estimate that 90% are misused by folks who apply them to silence a warning rather than write the code correctly.

[marwex89]

Aereshaa said:

Because you're jealous of our beautiful syntax! :p

lol I just wanted to point it out :P

Hawk1 said:

while you guys are in the thread....... how would i turn say, this.....

char newgame = 'y';

into a Toupper that actually works
or is that not the right context where to put the toupper

maybe here?

 cout << "Do you want to play again? (y / n)" << endl;
            cin >> newgame;

You could put it after this...

 cout << "Do you want to play again? (y / n)" << endl;
            cin >> newgame;

For reference on the function: toupper - Cprogramming C and C++ Function Reference
toupper - C++ Reference

dcs said:

Regarding casts, I'd estimate that 90% are misused by folks who apply them to silence a warning rather than write the code correctly.

lol yeah

[LukeyJ]

peace_and_quiet = static_cast<silence>(dcs);