4 replies to this topic

[rossen]

i have this code to test for palindromes, it functions perfectly well on the first test, but as the program continues to check for more after the first word it keeps printing not palindrome, once it wasnt the first word typed, run it pls, and you'll c what im talking about. Can anyone help me fix it..?

#include <stdio.h>
#include <ctype.h>
#include <string.h>

int isPalindrome( char *s);
int main (void)
{
int i=0;
int ch;
char s[100];
while (1){
while ((ch = getchar()) != ('\n')){
if (isalpha(ch)){
ch=toupper(ch);
s[i]=ch;
i++;
}
}
s[i]='\0';
if (isPalindrome(s) ==1){
printf("is palindrome\n");
}
else{
printf("not palindrome\n");
}
system("Pause");
return 0;
}

thanks,
-------------------------------------------

Edited by v0id, 11 June 2008 - 05:13 AM.

[Chinmoy]

Where is ispalindrome() defined?

[WingedPanther]

In your loop, you are continually incrementing i, so s will become something like the following:
s = "something\0else\0than\0expected\0"

You can see where you'll get issues.

[revealer]

I can't see isPalindrome() nor isAlpha() anywhere.

[Xav]

Presumably the functions are defined elsewhere, as rossen managed to get the code to work.