SQL or die issue

**hudbarnett** · 08-31-2010, 02:00 PM

I have this page and when the user added a username that is in the database already i get a horrid text error. All you see is the white page with the error. I would like to redirect the user to a page or add text which includes all the page HTML so it still has the look of the over all site.

The line in question is "or die ("Sorry there has been a problem with the registration, please click back and try again");"

Here is the php code

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<?php

// Check if he wants to register:
if (!empty($_POST[username]))
{
    // Check if passwords match.
    if ($_POST[password] != $_POST[password2])
        exit("Error - Passwords don't match. Please go back and try again.");

    // Assign some variables.
    $date = mktime("d - m - Y");
    $ip = $_SERVER[REMOTE_ADDR];

    require_once("connect.php");

    // Register him.
    $query = mysql_query("INSERT INTO members 
    (title, username, firstname, lastname, address, town, county, postcode, mobile, tennis_number, lta_number, itf_itn_number, age, club, website, showdetails, password, date, ip)
    VALUES    ('$_POST[title]','$_POST[username]','$_POST[firstname]','$_POST[lastname]','$_POST[address]','$_POST[town]','$_POST[county]','$_POST[postcode]','$_POST[mobile]','$_POST[tennis_number]','$_POST[lta_number]','$_POST[itf_itn_number]','$_POST[age]','$_POST[club]','$_POST[website]','$_POST[showdetails]','$_POST[password]','$date','$ip')")
    or die ("Sorry there has been a problem with the registration, please click back and try again");
    
    header("location:new_account.php");
        
    exit();
}

?>

Thanks

**DEViANT** · 08-31-2010, 02:14 PM

Try the following:

CODE REMOVED - CHECK NEXT POST

Check the comment fields for where you have to make changes. Untested - but it SHOULD work.

**DEViANT** · 08-31-2010, 02:19 PM

Updated :

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<?php

// Check if he wants to register:
if (!empty($_POST[username]))
{
    // Check if passwords match.
    if ($_POST[password] != $_POST[password2])
        exit("Error - Passwords don't match. Please go back and try again.");

    // Assign some variables.
    $date = mktime("d - m - Y");
    $ip = $_SERVER[REMOTE_ADDR];

    require_once("connect.php");

    // Register him.
    $q = mysql_query("SELECT username FROM members ORDER BY username ASC") or die(mysql_error());
    while($row = mysql_fetch_assoc($q))
    {
    	$arrnames[$i] = $row['username'];
    	$i++;
    }
    
    if(!in_array($_POST['username'],$arrnames))
    {
    	/*
    		Place what you want to 
    		have displayed in this 
    		block right here. This 
    		will be displayed if a 
    		username was found in 
    		the database that matches 
    		the given username
    		
    	*/
    	exit();
    } else {    
    	$query = mysql_query("INSERT INTO members 
    (title, username, firstname, lastname, address, town, county, postcode, mobile, tennis_number, lta_number, itf_itn_number, age, club, website, showdetails, password, date, ip)
    VALUES    ('$_POST[title]','$_POST[username]','$_POST[firstname]','$_POST[lastname]','$_POST[address]','$_POST[town]','$_POST[county]','$_POST[postcode]','$_POST[mobile]','$_POST[tennis_number]','$_POST[lta_number]','$_POST[itf_itn_number]','$_POST[age]','$_POST[club]','$_POST[website]','$_POST[showdetails]','$_POST[password]','$date','$ip')")
    or die ("Sorry there has been a problem with the registration, please click back and try again");
    
    header("location:new_account.php");
        
    exit();
}

?>

**Alexander** · 08-31-2010, 06:50 PM

It's much simpler than that.

Code:


$result = mysql_query("SELECT username FROM `members` WHERE `username` = '$username'");

if(mysql_num_rows($result) !== 0){
           die("Sorry! The user exists already");
}

Note 1: In your top code, do wrap non-constants in single or double quotes, $_POST[username] should be $_POST['username']
Note 2: mktime() is not correct, use date("d - m - Y")
Note 3: Consider using mysql_real_escape_string() around your $_POST elements in your query, this will prevent SQL injection.

**Orjan** · 09-01-2010, 12:53 AM

the sql needs to be like this, of course

Code:

SELECT username FROM `members` WHERE username = '$username'

Thread: SQL or die issue

LinkBack

Thread Tools

Search Thread

Display

SQL or die issue

Re: SQL or die issue

Re: SQL or die issue

Re: SQL or die issue

Re: SQL or die issue

Thread Information

Users Browsing this Thread

Similar Threads

VERY simple issue.

gcc issue

PHP 5.3 issue?

IE6 Issue

IE Issue

Tags for this Thread

Bookmarks

Bookmarks

Posting Permissions