char array

[RobotGymnast]

I'm having problem with a char array.. here's my code.. nice and simple (I took out the unnecessary stuff), but this only gives a popup saying "a".. I've tried various other things, and keys[0] never works.. what's up with that?

// Test.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include <windows.h>
#include <math.h>

class hack
{
	public:
		hack(char* hotkeys)
		{
			strcpy_s(keys,sizeof(keys),hotkeys);
			char* test = "a\0";
			test[0] = keys[0];
			MessageBox(0,test,"keys",MB_OK);
		};
		~hack()
		{
			
		}

		char  keys[6];
};

// create an array of hacks... what they affect
hack hacks[] =
	{
		hack("HP"	),
		hack("MH"	),
		hack("MP"	),
		hack("M"	),
		hack("A"	),
		hack("D"	),
		hack("P"	),
		hack("R"	),
		hack("S"	),
		hack("J"	),
		hack("RC"	),
		hack("YC"	),
		hack("HR"	),
		hack("MR"	)
	};
int _tmain(int argc, _TCHAR* argv[])
{
	return 0;
}

[dcs]

I wish that code were portable and not married to MS.

You should consider string literals to be read-only.

			char* test = "a\0";
			test[0] = keys[0];

Now if it didn't crash on my system, I might be more interested in digging further.

For my thick-headedness, could you describe the expected behavior?

[RobotGymnast]

I got it fixed.. you're right. If I change it from a pointer to a read-only string, to an array, it works