[John]

This:

([0-9]{3}-?)

simply groups "three digits and a dash" together. The {1,2} quantifier, says that the "three digits and a dash can occur once or twice."

Using your regular expression this may work

/[0-9]{3}-[0-9]{3}?-[0-9]{4}/

but I like mine better