Thread: Volunteer
View Single Post
  #7 (permalink)  
Old 08-15-2006, 10:24 AM
Jordan's Avatar   
Jordan Jordan is offline
Administrator
 
Join Date: Nov 2005
Location: Hendersonville, NC
Posts: 10,839
Last Blog:
PHP Security: Temporar...
Credits: 1
Rep Power: 20
Jordan is just really niceJordan is just really niceJordan is just really niceJordan is just really nice
Send a message via ICQ to Jordan Send a message via AIM to Jordan Send a message via MSN to Jordan
Default

I'm going to install it on a public server today (just so I can test the install). Would you like to give the URL out for testing to people that play your game?

Ok, here are some things that I would change:

1) In most of the files you have no comments. You should add more comments!

2) You have a ton of if statements at the top of each script:
PHP Code:
if($fn == 'player_name'){
$filename "Player";
}
elseif(
$fn == 'team_experience_points'){
$filename "Total";
}
elseif(
$fn == 'koth_experiencepoints'){
$filename "TKOTH";
}
elseif(
$fn == 'dm_experiencepoints'){
$filename "DM";
}
elseif(
$fn == 'flag_experiencepoints'){
$filename "CTF";
}
elseif(
$fn == 'bw_experiencepoints'){
$filename "BW";

and in most files it is the same statements. I would make an include file with those and just include them. Also, I would change the endifs to a select/case.

3) There isn't enough whitespace, for instance at the top of exp.php

PHP Code:
include "config.php";
include 
"english.php";
include 
"header.php";
$ordr = (isset($_GET['ordr']) ? $_GET['ordr'] : "asc"); 
I would change to

PHP Code:
// Include Files
include "config.php";
include 
"english.php";
include 
"header.php";

// Setup SQL Statement
$ordr = (isset($_GET['ordr']) ? $_GET['ordr'] : "asc"); 

Most of what I'm saying are just quirks of mine. The actual code looks fine.
__________________
CodeCall Blog | CodeCall Wiki | Shareware Site | Linux Forum | Write a Blog
The CodeCall Wiki is now fully integrated with vBulletin users! Check it out and add some new pages!
Reply With Quote